Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Error message with vscode.open command with option to create missing file #8

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FernandoAscencio
Copy link
Owner

@FernandoAscencio FernandoAscencio commented Mar 6, 2023

What it does

Adds user feedback when attempting to open a file that does not exist.
Partial implementation of 6568.
Closes 5667

How to test

  1. Install this extension. Based on the one provided in 6568.
  2. Run the Open Some File command.
  3. Verify the error message appears.

Additional Information

The list below are some interesting things that were found during testing and more detail regarding the testing file open-some-file-0.0.9.

  • Currently implementing a prompt to create the file is no issue, it just has not way of handling some of the test cases.
  • The Open Wrong command passes two location. One of a file and one of a folder, both with the same name. Theia creates a empty folder while VS Code prompts the user to create a file.
  • Open Nothing attempts to open a file with undefined URI.
  • Open Not Folder attempts to open a file with a URI that has an empty string as path.
  • Open Folder As File will open a folder as if it was a file.
  • No feedback when an unregistered command is called.

Review checklist

Reminder for reviewers

This commit finishes imlementations of eclipse-theia#6568
This commit closes eclipse-theia#5667

Signed-Off-By: FernandoAscencio <fernando.ascencio.cama@ericsson.com>
@FernandoAscencio FernandoAscencio changed the title [vscode] Error message with vscode.open command [vscode] Error message with vscode.open command with option to create missing file Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant