Skip to content

Commit

Permalink
Merge pull request #1 from FinanzRitter/feat/upgrade-to-ns7
Browse files Browse the repository at this point in the history
Feat/upgrade to ns7
  • Loading branch information
sc85 authored Oct 30, 2020
2 parents 587ead1 + 6d96226 commit 2ae7f81
Show file tree
Hide file tree
Showing 29 changed files with 4,847 additions and 4,592 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ My aim is to keep the features consistent across iOS and Android.
## Installation

```
tns plugin add nativescript-pdf-view
tns plugin add @finanzritter/nativescript-pdf-view
```

## Usage
Expand All @@ -31,7 +31,7 @@ tns plugin add nativescript-pdf-view
```xml
<Page
xmlns="http://schemas.nativescript.org/tns.xsd"
xmlns:pdf="nativescript-pdf-view"
xmlns:pdf="@finanzritter/nativescript-pdf-view"
loaded="pageLoaded">
<pdf:PDFView src="{{ pdfUrl }}" load="{{ onLoad }}" />
</Page>
Expand All @@ -40,7 +40,7 @@ tns plugin add nativescript-pdf-view
### Angular NativeScript

```ts
import { PDFView } from 'nativescript-pdf-view';
import { PDFView } from '@finanzritter/nativescript-pdf-view';
import { registerElement } from 'nativescript-angular';
registerElement('PDFView', () => PDFView);
```
Expand Down
2 changes: 1 addition & 1 deletion demo/app/App_Resources/Android/app.gradle
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
android {
defaultConfig {
generatedDensities = []
applicationId = "com.merott.nativescriptpdfviewdemo"
applicationId = "com.finanzritter.nativescript.pdfviewdemo"
}
aaptOptions {
additionalParameters "--no-version-vectors"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.merott.nativescriptpdfviewdemo"
package="com.finanzritter.nativescript.pdfviewdemo"
android:versionCode="1"
android:versionName="1.0">

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="app_name">PDF View Demo</string>
<string name="title_activity_kimera">PDF View Demo</string>
</resources>
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<string name="app_name">PDF View Demo</string>
<string name="title_activity_kimera">PDF View Demo</string>
</resources>
2 changes: 1 addition & 1 deletion demo/app/App_Resources/iOS/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<key>CFBundleDevelopmentRegion</key>
<string>en</string>
<key>CFBundleDisplayName</key>
<string>${PRODUCT_NAME}</string>
<string>PDF View Demo</string>
<key>CFBundleExecutable</key>
<string>${EXECUTABLE_NAME}</string>
<key>CFBundleInfoDictionaryVersion</key>
Expand Down
1 change: 0 additions & 1 deletion demo/app/app.css

This file was deleted.

5 changes: 2 additions & 3 deletions demo/app/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ You can use this file to perform app-level initialization, but the primary
purpose of the file is to pass control to the app’s first module.
*/

import * as application from "tns-core-modules/application";

application.run({ moduleName: "main-page" });
import { Application } from '@nativescript/core';
Application.run({ moduleName: 'main-page' });

/*
Do not place any code after the application has been started as it will not
Expand Down
4 changes: 1 addition & 3 deletions demo/app/main-page.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import { EventData } from "tns-core-modules/data/observable";
import { Page } from "tns-core-modules/ui/page";

import { EventData, Page } from '@nativescript/core';
import { MainViewModel } from './main-view-model';

// Event handler for Page 'loaded' event attached in main-page.xml
Expand Down
4 changes: 1 addition & 3 deletions demo/app/main-view-model.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Observable } from 'data/observable';
import { PDFView } from '@finanzritter/nativescript-pdf-view';
import { Observable } from '@nativescript/core';

export class MainViewModel extends Observable {
public pdfUrls = [
Expand All @@ -23,5 +22,4 @@ export class MainViewModel extends Observable {
}

private current = 0;
private enableAnnotationRendering = true;
}
11 changes: 0 additions & 11 deletions demo/app/package.json

This file was deleted.

12 changes: 12 additions & 0 deletions demo/nativescript.config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { NativeScriptConfig } from '@nativescript/core'

export default {
id: 'com.finanzritter.nativescript.pdfviewdemo',
appResourcesPath: 'app/App_Resources',
android: {
v8Flags: '--expose_gc',
markingMode: 'none',
},
useLegacyWorkflow: false,
appPath: 'app',
} as NativeScriptConfig
3 changes: 0 additions & 3 deletions demo/nsconfig.json

This file was deleted.

Loading

0 comments on commit 2ae7f81

Please sign in to comment.