Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased version of reverted #109 #205

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

greimel
Copy link
Contributor

@greimel greimel commented Jun 29, 2022

My initial PR #109 was merged and then reverted

out of concern with memory allocation

by @eloualiche. I benchmarked this PR vs master (using the middle regression model in benchmarks/benchmarks.jl

# PR
julia> @btime reg($df, @formula(y ~ x1 + x2 + fe(id1) + fe(id2)))
  2.842 s (38190 allocations: 97.22 MiB)

# master
@btime reg($df, @formula(y ~ x1 + x2 + fe(id1) + fe(id2)))
  2.713 s (35578 allocations: 90.64 MiB)

Is this difference significant enough to prevent this feature?

adjust esample


check for missings


fix


fix


work with esample2


clean up
@greimel
Copy link
Contributor Author

greimel commented Jun 30, 2022

I've gotten rid of the excess allocations.

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #205 (672dd78) into master (2662649) will decrease coverage by 0.63%.
The diff coverage is 89.36%.

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   96.08%   95.45%   -0.64%     
==========================================
  Files           8        8              
  Lines         588      638      +50     
==========================================
+ Hits          565      609      +44     
- Misses         23       29       +6     
Impacted Files Coverage Δ
src/FixedEffectModels.jl 100.00% <ø> (ø)
src/FixedEffectModel.jl 92.99% <76.19%> (-0.56%) ⬇️
src/partial_out.jl 91.66% <84.00%> (-3.86%) ⬇️
src/fit.jl 96.31% <97.91%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4887c70...672dd78. Read the comment docs.

@nilshg
Copy link
Contributor

nilshg commented Nov 9, 2023

Can this be closed as missing is now supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants