Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement elseif #198

Merged
merged 11 commits into from
Nov 27, 2023
Merged

Implement elseif #198

merged 11 commits into from
Nov 27, 2023

Conversation

MarkusFreitag
Copy link
Collaborator

@MarkusFreitag MarkusFreitag commented Oct 30, 2023

Implements if / elif / else like so:

if(false)
  puts("if")
elif(5 < 4)
  puts("else if")
else
  puts("else")
end

Blocked by the decision from issue #71

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rocket-lang ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 9:21pm
rocket-lang-play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 9:21pm

Flipez
Flipez previously approved these changes Oct 31, 2023
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0d64fb8) 87.46% compared to head (5c308df) 87.37%.

Files Patch % Lines
parser/if.go 68.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   87.46%   87.37%   -0.10%     
==========================================
  Files         106      106              
  Lines        3710     3731      +21     
==========================================
+ Hits         3245     3260      +15     
- Misses        398      402       +4     
- Partials       67       69       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Flipez <code@brauser.io>
@Flipez Flipez added the enhancement New feature or request label Nov 27, 2023
@Flipez Flipez merged commit 2c802b9 into main Nov 27, 2023
5 of 6 checks passed
@Flipez Flipez deleted the implement-elseif branch November 27, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants