Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

SubGhz: Display Weather Station temperature in units matching system locale #569

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

cquick01
Copy link
Contributor

What's new

  • Display temperature from Acurite weather stations in Celsius or Fahrenheit corresponding to system settings

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable (I've only actually tested with the Acurite-609TXC, but all four operate similarly)

@cquick01 cquick01 requested a review from ClaraCrazy as a code owner February 24, 2024 20:29
Co-authored-by: Connor Quick <72400253+cquick01@users.noreply.github.com>
@Willy-JL Willy-JL changed the title subghz: display Acurite temperature in units matching system locale SubGhz: Display Weather Station temperature in units matching system locale Feb 24, 2024
@Willy-JL
Copy link
Contributor

i feel like these protocols could be optimized a lot, they all have the same structure... this has to be taking up heaps of DFU flash for no reason...

either way thats unrelated to this PR. LGTM, thanks!

@Willy-JL Willy-JL merged commit c4cab4c into Flipper-XFW:dev Feb 24, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: 👀 Done (In next release)
Development

Successfully merging this pull request may close these issues.

2 participants