F/filter elevations #135
Open
F/filter elevations #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR would fix issue #130 , without any DEM stuff (taht can be done in another ENH issue)
I’ve implemented the
GpxMetricsComputationclass inweb/src/lib/models/gpx/gpx-metrics-computation.ts.This class accumulates points from a GPX track and computes the following metrics:
In
web/src/lib/models/gpx/gpx.ts, thegetTotals()method now uses this class to "smooth" elevation gain and loss, aiming for better accuracy.Implementation Details
I’ve chosen the following fixed thresholds:
These thresholds are currently not configurable, as they provide reasonably good results in most cases. However, depending on the track's characteristics we might need to adjust these thresholds in the future (e.g., a nearly flat track => lowering the Z threshold). Ho<ever, that's not easy, we would need a dataset with tracks and there known metrics.
Next Steps
Feel free to merge this PR or suggest alternative strategies for the computation or threshold configuration.