Update to using pyproject.toml #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the Python community is moving towards using pyproject.toml files to manage package and project information. This commit adds a pyproject.toml, removes the setup.py and and adds some instructions for running the tests with poetry. The github CI action was also updated.
|
Thanks for this, I wanted to do this, too; |
Allow Python v3.9 and higher to be used, and unpin dependencies for flexibility. Also, the GitHub action was updated so that it does the poetry install step, which is needed to install dependencies and to run pytest.
|
@Florents-Tselai good idea about loosening the versions and allowing older pythons. I just updated the PR to allow for pythons >= 3.9 (will that be enough, or should we go lower?). I also unpinned the dependencies to see if that will work going forward. I think I mostly just copied the requirement versions from the setup.py, but I liked the idea of leaving them looser, especially for getting newer/better versions of things as they become available. And I think I fixed the CI build, I had forgotten to install dependencies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the Python community is moving towards using pyproject.toml files to manage package and project information. This commit adds a pyproject.toml, removes the setup.py and and adds some instructions for running the tests with poetry. The github CI action was also updated.