Support import from WACZ files #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since WACZ files are ZIP files that contain WARC files at a particular directory location we can import them fairly easily, without requiring the ZIP file to be uncompressed to disk first. The added tests/scoop.wacz was created using the [scoop](https://github.com/harvard-lil/scoop) utility: ```shell $ scoop https://github.com/Florents-Tselai/WarcDB ``` Closes Florents-Tselai#15
edsu
commented
Oct 20, 2023
| import pytest | ||
| import sqlite_utils | ||
| from unittest import TestCase | ||
| from click.testing import CliRunner | ||
| from warcdb import warcdb_cli |
There was a problem hiding this comment.
This was just removing TestCase which was not used, and sorting them.
edsu
commented
Oct 20, 2023
| wacz = zipfile.ZipFile(f) | ||
| warcs = filter(lambda f: f.filename.endswith('warc.gz'), wacz.infolist()) | ||
| for warc in warcs: | ||
| yield from tqdm(ArchiveIterator(wacz.open(warc.filename, 'r'), arc2warc=True), desc=warc.filename) |
There was a problem hiding this comment.
This picks the WARC files out of the WACZ's archive directory, and creates an ArchiveIterator for each one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since WACZ files are ZIP files that contain WARC files at a particular directory location we can import them fairly easily, without requiring the ZIP file to be uncompressed to disk first.
The added test file
tests/scoop.waczwas created using the scoop utility:The only caveat is that loading WACZs from a URL is not yet supported.
Closes #15