Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable header content #1551

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

bartbutenaers
Copy link
Contributor

@bartbutenaers bartbutenaers commented Dec 20, 2024

Description

This PR replaces the following checkbox in the ui-base:

image

By this dropdown:

image

With the following result:

image

The header is automatically updated after a deploy.
And the old checkbox values are migrated to the new "page" or "none" values.

Remarks:

  • I had added a width of 70% to the dropdowns (like I normally do) to make them as long as the other input fields, so that the content of the longest option label fits into the dropdown (as in the above screenshot). But then the dropdowns jumped to the next line when I opened my config screen. So I have removed that again...
  • I have not updated the documentation (i.e. md and info panel) because it looks to me that those settings are not described yet...

Related Issue(s)

1545 and 1520

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

Copy link
Collaborator

@joepavitt joepavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great addition. I've also made the browser tab title align with the selection too, which defaults back to the page name in instances where the selection is "None" (as we already need a title in the browser tab)

@joepavitt joepavitt merged commit 6e66c17 into FlowFuse:main Dec 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants