Extract historical state mgmt into a datastore #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Further extension of the work already pushed in #275 and linked to fixes for #170 and #213.
The fix in #275 fixed a mismatch for referring to
node.when receiving client events, what this then affected was our state management, wherenode._msgwas lost in the old instance ofnode, so on refresh/re-deploy, this data was lost (previously it had maintained the event handlers on the oldnode).In this PR, I have extracted all server-side state management out of
node._msgpattern and into a commondatastoreservice. This will also be beneficial for third-party integrations, as they can extend that same datastore, and not need to build their own solutions.Adds "state management" documentation, and updates the events architecture diagram.
Checklist