Skip to content

Commit

Permalink
BUGFIX: Pass named arguments to executeCommand (#37)
Browse files Browse the repository at this point in the history
  • Loading branch information
kdambekalns authored and Bastian Waidelich committed Sep 5, 2018
1 parent 6d7bf4c commit 5287b4d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Classes/Job/JobManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public function waitAndExecute(string $queueName, $timeout = null): ?Message
if (isset($queueSettings['executeIsolated']) && $queueSettings['executeIsolated'] === true) {
$messageCacheIdentifier = sha1(serialize($message));
$this->messageCache->set($messageCacheIdentifier, $message);
Scripts::executeCommand('flowpack.jobqueue.common:job:execute', $this->flowSettings, false, [$queue->getName(), $messageCacheIdentifier]);
Scripts::executeCommand('flowpack.jobqueue.common:job:execute', $this->flowSettings, false, ['queue' => $queue->getName(), 'messageCacheIdentifier' => $messageCacheIdentifier]);
} else {
$this->executeJobForMessage($queue, $message);
}
Expand Down
4 changes: 2 additions & 2 deletions Classes/Queue/FakeQueue.php
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,9 @@ public function submit($payload, array $options = []): string
$this->messageCache->set($messageCacheIdentifier, $message);

if ($this->async) {
Scripts::executeCommandAsync('flowpack.jobqueue.common:job:execute', $this->flowSettings, [$this->name, $messageCacheIdentifier]);
Scripts::executeCommandAsync('flowpack.jobqueue.common:job:execute', $this->flowSettings, ['queue' => $this->name, 'messageCacheIdentifier' => $messageCacheIdentifier]);
} else {
Scripts::executeCommand('flowpack.jobqueue.common:job:execute', $this->flowSettings, true, [$this->name, $messageCacheIdentifier]);
Scripts::executeCommand('flowpack.jobqueue.common:job:execute', $this->flowSettings, true, ['queue' => $this->name, 'messageCacheIdentifier' => $messageCacheIdentifier]);
}
return $messageId;
}
Expand Down

0 comments on commit 5287b4d

Please sign in to comment.