Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like we have a problem induced by JuliaDiff/ChainRules.jl#441.
On ChainRules 0.8.10 the test introduced in this PR passes, while on 0.8.15 the zygote gradient errors out with
Besides the problem in the ChainRules' rule, I wonder why we don't hit the Zygote adjoint instead
Zygote.jl/src/lib/array.jl
Line 299 in 8d5efcb
I thought zygote's adjoints had priority over ChainRules' rules