Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods for
literal_getproperty
on the Cholesky factorisation are type-unstable. This instability stems from the value ofuplo
not being known at compile time as it's dynamic.The only way that I can see around this is to ensure that we arrive at the same type for the
factors
field regardless whetheruplo
is:L
or:U
.I'm not 100% happy with using
collect
-- it feels like it'll be a bad option for things likeCuArray
s, to which this rule does in principle apply I believe. @oxinabox @mcabbott @DhairyaLGandhi @devmotion any thoughts on another way of achieving the same thing?Note: this should not prevent us moving forward with #1114 as this doesn't interfere with the rrule for
cholesky
itself.