Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous methods on Grads #1486

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

ToucheSir
Copy link
Member

As far as I can tell, these were never used, tested or documented. Moreover, they don't make sense semantically since Grads behaves like a Dict rather than an ordinal-indexed collection like an Array. Meanwhile, their continued existence is causing issues like #1484.

PR Checklist

  • Tests are added
  • Documentation, if applicable

As far as I can tell, these were never used, tested or documented.
Moreover, they don't make sense semantically since `Grads` behaves like a Dict rather than an ordinal-indexed collection like an Array.
Meanwhile, their continued existence is causing issues like #1484.
@ToucheSir
Copy link
Member Author

After blaming the failed test code, it appears the src file blame is messed up on GH and the actual PR which introduced this does have tests + proper motivation for it. Now I'm not sure what we should do with this functionality. Deprecating it wouldn't get rid of the ambiguities, but it would set us up for removing it along with possibly more of the implicit grads machinery in the future (if we ever get around to that). Adding the suggested methods in #1484 would work, but feels rather unsatisfying and a little hacky. Maybe we could avoid ambiguities by restricting the list of broadcastable functions?

I wish https://docs.julialang.org/en/v1/manual/interfaces/#man-interfaces-broadcasting would be a little clearer on how to implement the interface, especially since this is Base's own internal overloads conflicting with us here. WDYT @CarloLucibello @darsnack?

@ToucheSir ToucheSir marked this pull request as draft December 31, 2023 06:13
@ToucheSir ToucheSir added discussion implicit using Params, Grads labels Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion implicit using Params, Grads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant