Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop to master #181

Merged
merged 10 commits into from
Feb 16, 2024
Merged

Merge develop to master #181

merged 10 commits into from
Feb 16, 2024

Conversation

GrylledCheez
Copy link
Collaborator

This is the initial Gnome-45 release

@joser93
Copy link

joser93 commented Feb 9, 2024

After a few minutes of testing, I can say that the PR works as intended, I've waiting for an update since I'm testing on Fedora 39, so I couldn't wait to see the approval.

Tested on GNOME Shell 45.3 on Wayland

There are some weird cases that during the rendering the resize of the window, glitches with the animation, not that anoying, but everything works as intended.

If you want to check the glitch and if it's something that you can fix, this is the step by step:

  1. Open any application
  2. Maximize the window if is not full maximize
  3. Press <Super> + <Right Arrow>
  4. Check the animation glitch on the left

I hope it helps and thanks for the effort, if there's any log or testing that I can provide to improve the extension, I'll be in touch. :D

@joser93
Copy link

joser93 commented Feb 9, 2024

I noticed that edge window resize is not working, when I posted before, I thought that wasn't implemented, but checking #103 make me doubt about that, then I don't know, if is a bug or is it working as intended.

Steps to reproduce:

  1. Open two resizable apps
  2. Move the window on the left and right side using <Super> + <Left arrow> and <Super> + <Right arrow>
  3. Drag any window from the edge between the windows

Current behavior:
Only one window resizes

Expected behavior:
The windows resizes

@GrylledCheez
Copy link
Collaborator Author

  1. What program are you trying to resize that causes the "animation glitch"?
  2. What kind of animation glitch is it? Please be descriptive.
  3. Only one window resizing at a time is the intended behavior. We might implement clustering later, but that's hard.

@joser93
Copy link

joser93 commented Feb 9, 2024

  1. What program are you trying to resize that causes the "animation glitch"?
  2. What kind of animation glitch is it? Please be descriptive.
  3. Only one window resizing at a time is the intended behavior. We might implement clustering later, but that's hard.

thanks for the reply

1 and 2, I add this video to showcase the rendering bug, if it's a mutter thing, then is a non issue and in the future won't ask again if someone sees that, but, if it's an issue for wintile, might help.

Grabacion.de.pantalla.desde.2024-02-09.17-45-52.webm
  1. I get it and thanks for being clear on that, still missed a good way to handle windows using wintile and I appreciate the effort on that :D

@GrylledCheez
Copy link
Collaborator Author

I think that's caused by us using the same ease out quad method for every animation. Put in a PR if you have any ideas.

@GrylledCheez
Copy link
Collaborator Author

@joser93, I can confirm that I'm not seeing the same glitch on my system. It must be a mutter issue like you said.

@GrylledCheez
Copy link
Collaborator Author

@Fmstrat and @phavekes, wake up.

@phavekes
Copy link
Collaborator

@Fmstrat and @phavekes, wake up.

Sorry, I'm not using this plugin anymore. I'm not the right person to test this.

@rolfmadsen
Copy link

I just installed the development branch on Ubuntu 23.10 and it works beautifully! :-)

@GrylledCheez
Copy link
Collaborator Author

just curious. did you use the release or the git clone?

Copy link
Collaborator

@phavekes phavekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by others. Code changes look fine.
Thanks for your work @GrylledCheez

@GrylledCheez GrylledCheez merged commit c2d6e2e into master Feb 16, 2024
2 checks passed
@GrylledCheez GrylledCheez deleted the develop branch February 16, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants