Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed from BACKOFF_MAX to DEFAULT_BACKOFF_MAX since it deprecated #922

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

andrwgldmn
Copy link

It needs to be changed from BACKOFF_MAX to DEFAULT_BACKOFF_MAX since it deprecated in urllib3 and causes an error after pressing a "Save changes" button in camera settings, e.g:

2023-08-27 14:52:56,233 - octoprint - ERROR - Exception on /plugin/octolapse/applyCameraSettings [POST]
Traceback (most recent call last):
  File "/home/octoprint/OctoPrint/venv/lib/python3.10/site-packages/flask/app.py", line 2529, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/octoprint/OctoPrint/venv/lib/python3.10/site-packages/flask/app.py", line 1825, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/octoprint/OctoPrint/venv/lib/python3.10/site-packages/flask/app.py", line 1823, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/octoprint/OctoPrint/venv/lib/python3.10/site-packages/flask/app.py", line 1799, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
  File "/home/octoprint/OctoPrint/venv/lib/python3.10/site-packages/octoprint/server/util/flask.py", line 1590, in decorated_view
    return no_firstrun_access(flask_login.login_required(func))(*args, **kwargs)
  File "/home/octoprint/OctoPrint/venv/lib/python3.10/site-packages/octoprint/server/util/flask.py", line 1613, in decorated_view
    return func(*args, **kwargs)
  File "/home/octoprint/OctoPrint/venv/lib/python3.10/site-packages/flask_login/utils.py", line 290, in decorated_view
    return current_app.ensure_sync(func)(*args, **kwargs)
  File "/home/octoprint/OctoPrint/venv/lib/python3.10/site-packages/octoprint_octolapse/__init__.py", line 1259, in apply_camera_settings_request
    success, error = self.apply_camera_settings([camera_profile])
  File "/home/octoprint/OctoPrint/venv/lib/python3.10/site-packages/octoprint_octolapse/__init__.py", line 1982, in apply_camera_settings
    success, errors = camera.CameraControl.apply_camera_settings(
  File "/home/octoprint/OctoPrint/venv/lib/python3.10/site-packages/octoprint_octolapse/camera.py", line 209, in apply_camera_settings
    thread.join(requests.packages.urllib3.util.retry.Retry.BACKOFF_MAX)
AttributeError: type object 'Retry' has no attribute 'BACKOFF_MAX'

changed from BACKOFF_MAX to DEFAULT_BACKOFF_MAX since it deprecated
@FormerLurker
Copy link
Owner

Sorry it's taken a while! Can you target the devel branch and I'll pull it in for testing?

@andrwgldmn
Copy link
Author

Sorry it's taken a while! Can you target the devel branch and I'll pull it in for testing?

how can I do it? make other pr to devel branch?

@FormerLurker
Copy link
Owner

Yeah, it's probably easiest to just start a new PR to the devel branch. There might be another way, but that's how I would do it. Feel free to close this one in that case, and THANK YOU SO MUCH for being patient and for your contribution!

I will leave this open for communication in the meantime.

@andrwgldmn andrwgldmn changed the base branch from master to devel November 9, 2023 18:50
@andrwgldmn
Copy link
Author

Yeah, it's probably easiest to just start a new PR to the devel branch. There might be another way, but that's how I would do it. Feel free to close this one in that case, and THANK YOU SO MUCH for being patient and for your contribution!

I will leave this open for communication in the meantime.

changed in this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants