Don't store sub-groups where not needed in regex and other processing optimisations #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives a slight optimisation to the "Processing comments" stage.
Tries to avoid potential backtracking from the first group and the possible leading whitespace given that the first group can also match leading whitespace.
|
Have now included another tweak which for the project I'm testing with has led to a reduction in the time spent processing comments by a factor of four, without missing any matches or hitting new matches (i.e. it gives the same results). I think the regex as is (and before any of the changes in this PR) might have some false positives, e.g. matching |
|
OK, now also fixed the potential match of a commented out line when searching for the end of a block. |
d7919
changed the title
ZedThree
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks SRC_CAPTURE_STR to avoid capturing the logical groups in this regex as we don't use them. This gives a slight optimisation to the "Processing comments" stage.
There are likely a few other places in sourceform that similar adjustments could be made, but they are less likely to give a noticeable speed up as, at least for the project I'm testing with, the SRC_CAPTURE_STR regex search dominates the processing comments stage.