fix add ssh certificate with existing key #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you cannot add or update a certificate if the key has already been loaded because
AddTPMKeywill exit if the public key fingerprint matches an existing key. It ignores the certificate that was provided in the request.Let's unconditionally replace the key so that the certificate attribute will be updated.
This enables using short lived ssh certificates which are common in enterprise environments. These certificates typically expire in a few hours.
One notable thing that will still not work is having multiple certificates per key. This can happen if there are multiple authorities in your organization or a authority rotation is in progress. These scenarios could be tolerated, but I think we should just do a simple fix for now.