fix mobile view #702
Open
fix mobile view #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
is this WIP? @Falacayir98 |
|
Yes, it was a WIP. I had to add the license and version in the mobile view. It is ready now |
qhantom
requested changes
Jan 14, 2025
There was a problem hiding this comment.
When there are more elements, the are not shown, maybe due to overflow: hidden:
| @@ -54,18 +60,21 @@ export function NavLinks({ links, userRights, foldedNav }: Props): JSX.Element { | |||
| (link.rights && hasRequiredRights(userRights, link.rights)) ? ( | |||
| <MantineNavLink | |||
| component={NextLink} | |||
| key={link.label} | |||
| key={link.label + link.icon} | |||
There was a problem hiding this comment.
Why that? Icon is a JSX Element, hence an object. We don't want to use objects as keys.
| @@ -320,7 +333,7 @@ export function AuthLayout({ children, ...props }: Props): JSX.Element | null { | |||
| ) : null} | |||
| </Footer> | |||
|
|
|||
| <AppShellMain>{children}</AppShellMain> | |||
| <AppShellMain style={{ overflow: 'hidden' }}>{children}</AppShellMain> | |||
There was a problem hiding this comment.
We don't apply inline-styling to elements. Please use the appropriate CSS file with a class. Is this change really necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
#679
TO-DO
CLOSES
closes list of issues closed in this PR