Migrate to eslint flat config (#1607)

.npmignore

@@ -21,14 +21,13 @@ public/source/
 public/vendor/
 
 # Ignore dot-files
-.eslintignore
-.eslintrc.json
 .gitattributes
 .mochaclicktest.json
 .mochatest.json
 .prettierignore
 .prettierrc
 appveyor.yml
+eslint.config.mjs
 tsconfig.json
 
 # Ignore docs

clicktests/environment.js

@@ -311,7 +311,7 @@ class Environment {
         timeout: 2000,
       }); // not all ref actions opens dialog, this line may throw exception.
       await this.awaitAndClick('.modal-dialog .btn-primary');
-    } catch (err) {
+    } catch {
       /* ignore */
     }
     await this.waitForElementHidden(`[data-ta-action="${action}"]:not([style*="display: none"])`);
@@ -396,7 +396,7 @@ class Environment {
   // Usually these events are triggered by mouse movements, or api calls
   // and etc.  This function is to help mimic those movements.
   triggerProgramEvents() {
-    return this.page.evaluate((_) => {
+    return this.page.evaluate(() => {
       const isActive = ungit.programEvents.active;
       if (!isActive) {
         ungit.programEvents.active = true;

clicktests/spec.generic.js

@@ -18,7 +18,7 @@ const amendCommit = async () => {
   try {
     await environment.page.waitForSelector('.amend-button', { visible: true, timeout: 2000 });
     await environment.click('.amend-button');
-  } catch (err) {
+  } catch {
     await environment.click('.amend-link');
   }
   await environment.ensureRedraw();
@@ -156,7 +156,6 @@ describe('[GENERIC]', () => {
     await environment.waitForElementHidden('.files .file .btn-default');
   });
 
-  // eslint-disable-next-line mocha/no-skipped-tests
   it.skip('Should be possible to patch a file', async () => {
     await changeTestFile(`${testRepoPaths[0]}/testfile.txt`, testRepoPaths[0]);
     //   .patch('patch')

components/home/home.js

@@ -32,7 +32,7 @@ class HomeRepositoryViewModel {
       .then((remote) => {
         this.remote(remote.address.replace(/\/\/.*?@/, '//***@'));
       })
-      .catch((err) => {
+      .catch(() => {
         this.remote('');
       });
   }

components/login/login.js

@@ -22,7 +22,7 @@ class LoginViewModel {
           this.status('login');
         }
       })
-      .catch((err) => {});
+      .catch(() => {});
   }
 
   updateNode(parentElement) {
@@ -32,7 +32,7 @@ class LoginViewModel {
   login() {
     this.server
       .postPromise('/login', { username: this.username(), password: this.password() })
-      .then((res) => {
+      .then(() => {
         this.loggedIn.dispatch();
         this.status('loggedIn');
       })

components/path/path.js

@@ -26,7 +26,7 @@ class SubRepositoryViewModel {
       .then((remote) => {
         this.remote(remote.address.replace(/\/\/.*?@/, '//***@'));
       })
-      .catch((err) => {
+      .catch(() => {
         this.remote('');
       });
   }

components/remotes/remotes.js

@@ -78,7 +78,7 @@ class RemotesViewModel {
         errorMessage = `Ungit has failed to fetch a remote.  ${err.res.body.error}`;
         stdout = err.res.body.stdout;
         stderr = err.res.body.stderr;
-      } catch (e) {
+      } catch {
         errorMessage = '';
       }
 

components/repository/repository.js

@@ -84,7 +84,7 @@ class RepositoryViewModel {
             });
         }
       })
-      .catch((err) => {
+      .catch(() => {
         this.parentModuleLink(undefined);
         this.parentModulePath(undefined);
       });

eslint.config.mjs

@@ -0,0 +1,120 @@
+import js from '@eslint/js';
+import globals from 'globals';
+import mochaPlugin from 'eslint-plugin-mocha';
+import nodePlugin from 'eslint-plugin-n';
+import prettierPlugin from 'eslint-plugin-prettier/recommended';
+
+export default [
+  {
+    ignores: ['public/js', '**/*.bundle.js'],
+  },
+
+  js.configs.recommended,
+  mochaPlugin.configs.flat.recommended,
+  nodePlugin.configs['flat/recommended'],
+  prettierPlugin,
+
+  // components
+  {
+    files: ['components/**'],
+
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ungit: 'readonly',
+      },
+    },
+
+    rules: {
+      'n/no-missing-require': 'off',
+      'n/no-unsupported-features/node-builtins': 'off',
+    },
+  },
+
+  // public/source
+  {
+    files: ['public/source/**'],
+
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        io: 'readonly',
+        jQuery: 'writable',
+        Raven: 'readonly',
+        ungit: 'readonly',
+      },
+    },
+
+    rules: {
+      'n/no-missing-require': 'off',
+      'n/no-unsupported-features/node-builtins': 'off',
+    },
+  },
+
+  // public/main.js
+  {
+    files: ['public/main.js'],
+
+    rules: {
+      'n/no-unpublished-require': [
+        'error',
+        {
+          allowModules: ['electron'],
+        },
+      ],
+    },
+  },
+
+  // source
+  {
+    files: ['source/**'],
+
+    rules: {
+      'no-control-regex': 'off',
+      'n/no-process-exit': 'off',
+    },
+  },
+
+  // test
+  {
+    files: ['test/**'],
+
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ...globals.mocha,
+        ...globals.node,
+      },
+    },
+
+    rules: {
+      'mocha/no-mocha-arrows': 'off',
+    },
+  },
+
+  // clicktests
+  {
+    files: ['clicktests/**'],
+
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ungit: 'readonly',
+      },
+    },
+
+    rules: {
+      'mocha/no-mocha-arrows': 'off',
+      'mocha/no-setup-in-describe': 'off',
+    },
+  },
+
+  // eslint.config.mjs
+  {
+    files: ['eslint.config.mjs'],
+
+    languageOptions: {
+      sourceType: 'module',
+    },
+  },
+];