Annotate false positive overflow_const issues (CID #1604607, #1604626) #5358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverity sees the initialization of hash and the multiplication by FNV_MAGIC_PRIME and points out that the product is too large for a uint32_t, but because the multiplication is done in an unsigned type, that is defined behavior and the intended behavior for the hash functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverity sees the initialization of
hashand the multiplication byFNV_MAGIC_PRIMEand points out that the product is too large for auint32_t, but because the multiplication is done in an unsigned type, that is defined behavior and the intended behavior for the hash functions.