Actually fill fr_rand_pool.randrsl #5361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In fr_rand_init(), where /dev/urandom is available, the code as written would always read into the beginning of fr_rand_pool.randrsl, so that only the first max(read returnh value) bytes would be filled. (Not associated with CID #1604611, but found while looking into it.)
|
Nice! Is this also applicable to v3? |
|
Don't know; where can I find the v3 code? |
|
No need to be inconsistent with "fill the random pool" (d5276a8); will resubmit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
fr_rand_init(), where/dev/urandomis available, the code as written would always read into the beginning offr_rand_pool.randrsl, so that only the first max(read return value) bytes would be filled.(Not associated with CID #1604611, but found while looking into it.)