Define vApplicationGetTimerTaskMemory only when configUSE_TIMERS is set #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazardyKnusperkeks
force-pushed
the
timerMemory
branch
from
ab86adf
to
a1c2673
Compare
ActoryOu
approved these changes
Jul 24, 2024
ActoryOu
approved these changes
Jul 24, 2024
chinglee-iot
approved these changes
Jul 24, 2024
kstribrnAmzn
approved these changes
Jul 24, 2024
|
I don't think the link-verifier fail is related to my change. |
You are right. It is not because of your change. We are looking into it. |
|
@aggarg I'm not an admin on this repo so I cannot override the merge with checks failing. I feel comfortable merging this in without the link verifying passing - I have verified the link verifier tool is failing to verify Segger's wiki site cert. Would you be able to merge this in without the check passing? |
|
@HazardyKnusperkeks Can you update your branch from latest main. That should address the link-verifier check. |
Otherwise it is very reasonable that config_TIMER_TASK_STACK_DEPTH is undefined.
HazardyKnusperkeks
force-pushed
the
timerMemory
branch
from
a1c2673
to
a24f0e9
Compare
|
Done. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it is very reasonable that config_TIMER_TASK_STACK_DEPTH is undefined.
Description
Add the
vApplicationGetTimerTaskMemorys#ifthe conditionconfigUSE_TIMERS ==1.Test Steps
Define
configSUPPORT_STATIC_ALLOCATION, andconfigKERNEL_PROVIDED_STATIC_MEMORY, but notconfigTIMER_TASK_STACK_DEPTH, you get a compiler error, thatconfigTIMER_TASK_STACK_DEPTHis undefined.Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.