Only check for stream buffer dependencies, if configUSE_STREAM_BUFFERS==1 #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S==1. Signed-off-by: Daniel Otte <d.otte@wut.de>
|
kar-rahul-aws
approved these changes
Aug 5, 2024
aggarg
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only check for stream buffer dependencies, if configUSE_STREAM_BUFFERS==1.
Description
The checks for
configUSE_TASK_NOTIFICATIONSandINCLUDE_xTaskGetCurrentTaskHandle, are now placed after the check forconfigUSE_STREAM_BUFFERS==1, and hence only performed if support for stream buffers is actually requested.Test Steps
Setting
configUSE_STREAM_BUFFERSandconfigUSE_TASK_NOTIFICATIONSand/orINCLUDE_xTaskGetCurrentTaskHandleto 0 will trigger a compilation error. This is also described in #1108 .Checklist:
Related Issue
This PR addresses issue #1108 .
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.