Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements and Bug Fixes for F1Kx Port #1169

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

TrongNguyenR
Copy link
Contributor

Description

  • Fixed interrupt depth comparison logic to enhance accuracy in handling nested interrupts.
  • Resolved parameter mismatch in portmacro.h, aligning function calls and definitions for consistency.
  • Addressed FPU stack order issue to ensure correct stack management during FPU operations.
  • Improved FPU checking flow, optimizing the process to better handle FPU-related context switching.

Test Steps

The test project here (RH850_F1Kx_CCRH) has been re-conducted, and no regressions were found.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

N/A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@TrongNguyenR TrongNguyenR requested a review from a team as a code owner October 31, 2024 13:05
@ActoryOu
Copy link
Member

ActoryOu commented Nov 1, 2024

Hi @TrongNguyenR,
Thanks for your contribution! I'll reach out to my colleague to help review this.
At the meanwhile, could you help fix the This branch is out-of-date with the base branch issue on the PR?

Thank you.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (61440fc) to head (53cdcd9).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
- Coverage   95.90%   92.27%   -3.63%     
==========================================
  Files           6        6              
  Lines        3225     3225              
  Branches      884      884              
==========================================
- Hits         3093     2976     -117     
  Misses        132      132              
- Partials        0      117     +117     
Flag Coverage Δ
unittests 92.27% <ø> (-3.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ActoryOu
Copy link
Member

ActoryOu commented Nov 4, 2024

I don't have permission to update your forked repo.
Could you help rebase this PR with latest main branch?

Steps:

  1. git co main
  2. git pull (from FreeRTOS/FreeRTOS-Kernel)
  3. git co f1kx_port
  4. git rebase main (from FreeRTOS/FreeRTOS-Kernel)
  5. git push (to renesas)

Thank you.

@trongnguyen215
Copy link

Hi @ActoryOu,
We have synced our fork repos. There are new commits for 2 days.
Please check it. Thank you.

@aggarg
Copy link
Member

aggarg commented Nov 4, 2024

Please rebase on top of main to fix CI spell check.

@ActoryOu
Copy link
Member

ActoryOu commented Nov 5, 2024

Hi @TrongNguyenR,
We might need your help to rebase the PR because we don't have write permission on this forked repo.
Then we can merge this as it's received two review approvals.

Fix parameter mismatch in portmacro.h file
Add comment to explain assembly code
Copy link

sonarcloud bot commented Nov 5, 2024

@trongnguyen215
Copy link

Hi @ActoryOu,
We just done rebasing to latest main.

@aggarg aggarg merged commit d0d55f3 into FreeRTOS:main Nov 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants