Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MPU wrapper for pcTaskGetName API #737

Merged
merged 7 commits into from
Aug 4, 2023

Conversation

kar-rahul-aws
Copy link
Member

@kar-rahul-aws kar-rahul-aws commented Aug 2, 2023

Description

This PR makes MPU_pcTaskGetName privileged only. This is done because it returns a pointer from TCB which an unprivileged cannot de-reference.

Test Steps

Run soak tests on ARMv7M and ARMv8M ports.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

https://forums.freertos.org/t/questions-about-mpu-implement-on-armv8-m/17915

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kar-rahul-aws kar-rahul-aws requested a review from a team as a code owner August 2, 2023 12:32
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a5bf4d9) 94.35% compared to head (8bab713) 94.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #737   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files           6        6           
  Lines        2443     2443           
  Branches      598      598           
=======================================
  Hits         2305     2305           
  Misses         85       85           
  Partials       53       53           
Flag Coverage Δ
unittests 94.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chinglee-iot chinglee-iot self-requested a review August 4, 2023 06:42
@kar-rahul-aws kar-rahul-aws merged commit 02be485 into FreeRTOS:main Aug 4, 2023
13 checks passed
@kar-rahul-aws kar-rahul-aws deleted the pcTaskGetName_MPU_fix branch August 4, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants