-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use INFINITE_LOOP macro for loop control in unit test #783
Use INFINITE_LOOP macro for loop control in unit test #783
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 6 6
Lines 2508 2508
Branches 598 598
=======================================
Hits 2348 2348
Misses 107 107
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
The uncovered line is because there is no unit test to cover it. This PR doesn't change the logic in the implementation. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Use the following pattern for loop control in unit test.
In the unit test, the configCONTROL_INFINITE_LOOP can be defined to a mocked function for loop controlling.
Test Steps
N/A
Checklist:
I have modified and/or added unit-tests to cover the code changes in this Pull Request.Related Issue
Address #750 comment in line 290.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.