Merge branch 'main' into dev-frame-filter

.github/workflows/ci.yml

@@ -33,11 +33,12 @@ jobs:
           cd ../..
           sudo apt-get install -y lcov
           sudo apt-get install -y unifdef
+          sudo apt-get install -y ninja-build
           echo "::endgroup::"
 
           echo "::group:: ${{ env.stepName }}"
-          cmake -S test/unit-test -B test/unit-test/build/
-          make -C test/unit-test/build/ all
+          cmake -S test/unit-test -B test/unit-test/build/ -G Ninja
+          cmake --build test/unit-test/build/ --target all
           echo "::endgroup::"
           echo -e "${{ env.bashPass }} ${{ env.stepName }} ${{ env.bashEnd }}"
 
@@ -59,7 +60,7 @@ jobs:
         run: |
           # ${{ env.stepName }}
           echo "::group::Build Tests"
-          make -C test/unit-test/build/ coverage
+          cmake --build test/unit-test/build/ --target coverage
           echo "::endgroup::"
           echo -e "${{ env.bashPass }} Built Coverage Tests ${{ env.bashEnd }}"
 

MISRA.md

@@ -34,6 +34,21 @@ _Ref 4.12.1_
   in the code to not use free'd pointers and to check the validity of malloc'd
   memory before it is dereferenced or used.
 
+#### Directive 4.14
+
+_Ref 4.14.1_
+
+- MISRA C:2012 Directive 4.14: The validity of values received from external
+  sources shall be checked. In this case however, the value of `uxICMPSize` is
+  checked to be within bounds of the network buffer size using the variable `uxNeededSize`. This is a false positive.
+
+_Ref 4.14.2_
+
+- MISRA C:2012 Directive 4.14: The validity of values received from external
+  sources shall be checked. In this case however, the contents of `xReceiveBuffer.pucPayloadBuffer` is filled by `FreeRTOS_recvfrom` which performs the necessary
+  checks required to validate the `xBytes` which is in turn assigned to
+  `xReceiveBuffer.uxPayloadLength`.
+
 #### Rule 2.2
 
 _Ref 2.2.1_
@@ -174,6 +189,16 @@ _Ref 17.2.1_
   listening state. Thus it is not possible for the child to have a secondary
   child socket thereby limiting the number of recursive calls to one.
 
+#### Rule 18.4
+
+_Ref 18.4.1_
+
+- MISRA C-2012 Rule 18.4 warns about using arithmetic operators such as `+`, `-`,
+  `+=`, and `-=` not to be applied to an expression of pointer type. In this case
+  however its ensured by review that, the explicitly calculated pointer value
+  doesn't have the potential to access unintended or invalid memory addresses.
+
+
 #### Rule 20.5
 
 _Ref 20.5.1_

source/CMakeLists.txt

@@ -89,8 +89,7 @@ target_sources( freertos_plus_tcp
       FreeRTOS_UDP_IPv6.c
 )
 
-# Note: Have to make system due to compiler warnings in header files.
-target_include_directories( freertos_plus_tcp SYSTEM
+target_include_directories( freertos_plus_tcp
   PUBLIC
     include
 )