Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error because of 'xMDNS_MACAddressIPv6' #1167

Closed
htibosch opened this issue Jul 7, 2024 · 2 comments
Closed

Compilation error because of 'xMDNS_MACAddressIPv6' #1167

htibosch opened this issue Jul 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@htibosch
Copy link
Contributor

htibosch commented Jul 7, 2024

Describe the problem

I am proposing the following change :

     const MACAddress_t xLLMNR_MacAddress;
     const MACAddress_t xLLMNR_MacAddressIPv6;
     const MACAddress_t xMDNS_MacAddress;
-    const MACAddress_t xMDNS_MACAddressIPv6;
+    const MACAddress_t xMDNS_MacAddressIPv6;

xMDNS_MACAddressIPv6 is the only identifier who writes _MAC with capitals.

  • Target
  • Host

Any target or host

  • Use project ... and configure with ...

Compile a project using either STM32Hxx, Zynq, or DriverSAM.
Enable ipconfigUSE_MDNS and ipconfigUSE_IPv6.

I think that _MACAddress with capitals is more correct, because MAC is an abbreviation. However, _MacAddress is maybe easier to read.

It would be nice to have a solution that is downward compatible, such as:

    const MACAddress_t xMDNS_MacAddressIPv6;
    #define xMDNS_MACAddressIPv6  xMDNS_MacAddressIPv6

Note that user-written modules are free to use xMDNS_MACAddressIPv6, and we don't want to break existing code.

@htibosch htibosch added the bug Something isn't working label Jul 7, 2024
@ActoryOu
Copy link
Member

Hi @htibosch,
Yeah, I agree that we should align the naming to xMDNS_MacAddressIPv6.
I would raise a PR for this.

Thank you!

@ActoryOu
Copy link
Member

Closing because fix was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants