We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the problem
I am proposing the following change :
const MACAddress_t xLLMNR_MacAddress; const MACAddress_t xLLMNR_MacAddressIPv6; const MACAddress_t xMDNS_MacAddress; - const MACAddress_t xMDNS_MACAddressIPv6; + const MACAddress_t xMDNS_MacAddressIPv6;
xMDNS_MACAddressIPv6 is the only identifier who writes _MAC with capitals.
xMDNS_MACAddressIPv6
_MAC
Any target or host
Compile a project using either STM32Hxx, Zynq, or DriverSAM. Enable ipconfigUSE_MDNS and ipconfigUSE_IPv6.
STM32Hxx
Zynq
DriverSAM
ipconfigUSE_MDNS
ipconfigUSE_IPv6
I think that _MACAddress with capitals is more correct, because MAC is an abbreviation. However, _MacAddress is maybe easier to read.
_MACAddress
_MacAddress
It would be nice to have a solution that is downward compatible, such as:
const MACAddress_t xMDNS_MacAddressIPv6; #define xMDNS_MACAddressIPv6 xMDNS_MacAddressIPv6
Note that user-written modules are free to use xMDNS_MACAddressIPv6, and we don't want to break existing code.
The text was updated successfully, but these errors were encountered:
Hi @htibosch, Yeah, I agree that we should align the naming to xMDNS_MacAddressIPv6. I would raise a PR for this.
xMDNS_MacAddressIPv6
Thank you!
Sorry, something went wrong.
Closing because fix was merged.
No branches or pull requests
Describe the problem
I am proposing the following change :
xMDNS_MACAddressIPv6
is the only identifier who writes_MAC
with capitals.Any target or host
Compile a project using either
STM32Hxx
,Zynq
, orDriverSAM
.Enable
ipconfigUSE_MDNS
andipconfigUSE_IPv6
.I think that
_MACAddress
with capitals is more correct, because MAC is an abbreviation. However,_MacAddress
is maybe easier to read.It would be nice to have a solution that is downward compatible, such as:
Note that user-written modules are free to use
xMDNS_MACAddressIPv6
, and we don't want to break existing code.The text was updated successfully, but these errors were encountered: