Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'xMDNS_MACAddressIPv6' with 'xMDNS_MacAddressIPv6' to increas… #1169

Merged

Conversation

htibosch
Copy link
Contributor

Replace 'xMDNS_MACAddressIPv6' with 'xMDNS_MacAddressIPv6' to increase uniformity

This PR will make the following change:

     const MACAddress_t xLLMNR_MacAddress;
     const MACAddress_t xLLMNR_MacAddressIPv6;
     const MACAddress_t xMDNS_MacAddress;
-    const MACAddress_t xMDNS_MACAddressIPv6;
+    const MACAddress_t xMDNS_MacAddressIPv6;

for the sake of uniformity.
A define will be added to make this change "backward compatible":

/* This type-name was formally "misspelled" as
 * xMDNS_MACAddressIPv6 with "MAC": */
    extern const MACAddress_t xMDNS_MacAddressIPv6;
    /* Guarantee backward compatibility. */
    #define xMDNS_MACAddressIPv6    xMDNS_MacAddressIPv6
#endif /* ipconfigUSE_MDNS */

Test Steps

Enable ipconfigUSE_MDNS and ipconfigUSE_IPv6, and one of these drivers: STM32Hxx, Zynq, or DriverSAM.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@htibosch htibosch requested a review from a team as a code owner July 10, 2024 04:30
@ActoryOu
Copy link
Member

Thank you for creating this! Note that this PR is created for #1167.

@ActoryOu ActoryOu merged commit 297cce5 into FreeRTOS:main Jul 10, 2024
10 checks passed
@htibosch htibosch mentioned this pull request Jul 29, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants