Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Missing parameters and undefined macros #1190

Closed
lightning51522 opened this issue Sep 24, 2024 · 3 comments
Closed

[BUG]Missing parameters and undefined macros #1190

lightning51522 opened this issue Sep 24, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@lightning51522
Copy link

I am currently porting TCP packets of version 4.2.2 Release. On ATSAM4E, I have found issues with missing parameters when calling functions in the network interface source file, as well as the use of an undefined macro。

1.The function usGeneratedProtocolChecksum called in line 422 of the portable/NetworkInterface/ATSAM4E/NetworkInterface. c file is missing a length parameter.
2.The macro ipLOCAL_MAC_ADDRESS used on line 315 of the same file has not been defined.

Hope these errors can be fixed

@lightning51522 lightning51522 added the bug Something isn't working label Sep 24, 2024
@kar-rahul-aws
Copy link
Member

kar-rahul-aws commented Sep 25, 2024

Hi @lightning51522
I have raised a PR for fixing the missing parameter issue in ATSAM4E port. Thanks for pointing out the issue.
Regarding your other concern, DriverSAM replaces the older ATSAM4E port. So, you can use this port in your project .
You can take a look at this PR , and make similar changes to the ATSAM4E port and raise a PR. We will be happy to review it.

Thanks.

@jasonpcarroll
Copy link
Member

Can this issue be closed?

@kar-rahul-aws
Copy link
Member

Closing this issue since the [PR] (#1192) has been merged. Please reopen this issue if you feel otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants