Fix missing parameters error in ATSAM4E #1192
Merged
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htibosch
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Thank you Rahul for this PR. Although it's in DRAFT state, I already checked it.
It should be said that DriverSAM replaces the older ATSAM4E. Maybe we can add a warning by adding __attribute__((deprecated)), or #warning?
The ap in apBuffer stands for "argument pointer", an old C++ habit that I have. Thanks for replacing it.
|
Thanks Hein for the review . Since the user wanted to fix the network interface initialization issue for ATSAM4E port, I had kept the PR in draft state for future commits if necessary. I will inform the user to use DriverSAM port instead and look into your suggestion for adding a |
aggarg
approved these changes
Sep 25, 2024
tony-josi-aws
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes missing parameters error in ATSAM4E.
Test Steps
NA
Checklist:
Related Issue
#1190
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.