Cleanup of some obsolete config structs #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… appear to be obsolete.
|
Thank you for your contribution, I'll pass this along to our reviewers for review. |
moninom1
changed the title
moninom1
approved these changes
Sep 8, 2023
shubnil
approved these changes
Sep 8, 2023
tony-josi-aws
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the xNetworkAddressing and xDefaultAddressing structs as they appear to be obsolete.
I can also extend this PR by removing any use of NetworkAddressingParameters_t from the unit-tests. I'm not very comfortable with modifying unit-tests, but this seems like a simple change.
Let me know if you think it's a good idea or if I should leave the unit-tests alone.
Checklist:
Related Issue
none
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.