Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve frame filtering #1100
Improve frame filtering #1100
Changes from 17 commits
bda977e
857638b
a205317
9718f55
046ec05
c1db70f
3136cbd
6cac71e
f3d960f
b5a21d1
28ae29b
02d1ddc
fc52baa
6289c9c
a3c6c04
982c47d
39d6a18
ec21554
499b5ff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MISRA 2012:
else if
constructs should be terminated with non-emptyelse
case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that else is reached, should we release the buffer? The destination address would be unsupported I guess.
Edit: Shouldn't we check for 0x01005E for IPv4 multicast, similar to how we do for IPv6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I believe its good to release the buffer.
For multicast support, this check should be required. It would be good to use the new multicast MAC address macros in
vSetMultiCastIPv4MacAddress
as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small side note:
In #1019 I've changed this check to allow all multicast MAC addresses if
ipconfigSUPPORT_IP_MULTICAST
is enabled. I might change that in the future, but with multicasts enabled and especially ifipconfigPROCESS_CUSTOM_ETHERNET_FRAMES
is enabled, it really is too early to drop any multicasts at this stage.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change the multicast filtering part after that goes in, for now it just drops ipv6 multicasts if ipv6 is disabled and vice versa for ipv4