Remove ipconfigHAS_ROUTING_STATISTICS #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-routing-stats
branch
from
b7d71be
to
a360292
Compare
tony-josi-aws
previously approved these changes
Jun 7, 2024
ActoryOu
previously approved these changes
Jul 30, 2024
ActoryOu
approved these changes
Jul 30, 2024
shubnil
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a half baked debugging option with arbitrary values. A Routing Stats implementation would be beneficial, but it should be something a bit more concrete that doesn't add a poorly defined parameter to half the routing functions.