Handle malloc failure in dns setcallback #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinglee-iot
previously approved these changes
Jun 14, 2024
shubnil
previously approved these changes
Jun 14, 2024
There was a problem hiding this comment.
This PR looks good, however there are some places where the strcpy is not doing a size check and as the source pointers are coming from application there is a potential schenario where out of buffer copy can happen. Please check if we can create a new PR for the same.
| { | ||
| BaseType_t xReturn = pdPASS; |
There was a problem hiding this comment.
- Can the strcpy in line 158 cause a copy overflow. We can use strncpy instead or put a size check as the destination is a fixed array
shubnil
approved these changes
Jun 14, 2024
chinglee-iot
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles malloc failure while allocating memory for DNS callback in
vDNSSetCallBackAPI.Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.