Bugfix in ATSAME5x network interface. Incorrect detection of ICMP #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kets when CRC offloading is enabled.
There was a problem hiding this comment.
Hi @cruxic ,
Thank you for this PR. Looks fine to me. I do not currently have an ATSAME5x with me - would you mind running this version of your code in your project and verifying that it works?
htibosch
reviewed
Sep 28, 2024
htibosch
reviewed
Sep 28, 2024
| if( pxIPPacket->xIPHeader.ucProtocol == ( uint8_t ) ipPROTOCOL_ICMP ) | ||
| { | ||
| * It must therefore be implemented in software. */ | ||
| if ( isICMP(pxBufferDescriptor) ) { |
There was a problem hiding this comment.
The if statement expects a boolean value. The function isICMP() returns an integer value. The only way to satisfy the compiler is as follows:
if( isICMP( pxBufferDescriptor ) == pdTRUE )
{
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for issue #1193.
Note: although I have an ATSAME53 board, I have not compiled or executed the code in this pull-request. My own project uses a customized version of this code.
I also noticed that this same bug exists in the MSP432 driver. This pull-request does not fix that.