[IPv6][SAM] Enable multicast hash table for multiple MAC addresses on SAM network interface

[ActoryOu]

[IPv6][SAM] Enable multicast hash table for multiple MAC addresses on SAM network interface

Description

The change is made by @htibosch.

When IPv6/Multiple endpoints enabled, the space to store MAC addresses is not enough.
To support it better, use multicast hash table in hardware to reduce loading on space.

Test Steps

Below scenarios are tested (by @htibosch) on both IPv4/IPv6:

• DNS
• UDP
• TCP
• Ping
• IPERF3

Checklist:

• I have tested my changes. No regression in existing tests.
• I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[tony-josi-aws]

Maybe its more cleaner (or more readable) to have different names for variables (pxEndPoint) though they are in different scope.

[htibosch]

Thank you Actory for creating this PR.
What I miss is a few items in the description of the PR:

• The name of the NetworkInterface will change from "GMAC" to "GMAC1", depending on the assigned index.
• The function pxSAM_FillInterfaceDescriptor() now calls FreeRTOS_AddNetworkInterface(), as it should
• Adapted vGMACGenerateChecksum() for use with IPv6 addresses
• An event passed to the IP-task does not have to be declared static as in static IPStackEvent_t xRxEvent
• When FreeRTOS_MatchingEndpoint() does not find a match, drop the received packet

Some remarks:

The function name prvAddMACAddress() is too generic. Maybe we should call it prvAddMulticastMACAddress()
At the bottom there is the function gmac_enable_irq(). I used it for testing: it makes stepping easier. You can remove the declaration.

[ActoryOu]

Thank you Actory for creating this PR. What I miss is a few items in the description of the PR:

• The name of the NetworkInterface will change from "GMAC" to "GMAC1", depending on the assigned index.
• The function pxSAM_FillInterfaceDescriptor() now calls FreeRTOS_AddNetworkInterface(), as it should
• Adapted vGMACGenerateChecksum() for use with IPv6 addresses
• An event passed to the IP-task does not have to be declared static as in static IPStackEvent_t xRxEvent
• When FreeRTOS_MatchingEndpoint() does not find a match, drop the received packet

Some remarks:

The function name prvAddMACAddress() is too generic. Maybe we should call it prvAddMulticastMACAddress() At the bottom there is the function gmac_enable_irq(). I used it for testing: it makes stepping easier. You can remove the declaration.

Thanks for additions.
I've updated prvAddMACAddress to prvAddMulticastMACAddress and removed gmac_enable_irq.

Please help to take a look.
Thanks.

[tony-josi-aws]

When adding IPv6 multi-cast MAC addresses of the IPv6 endpoints to the hash table, shouldn't it be of the form - Address Mapping -- Multicast

[shubnil]

This looks like a valid issue and the field ucMACAddress[ 2 ] needs to be set as well.

[htibosch]

Change will be reverted, see Solicited-node multicast address. It is used to give the DUT a multicast address which is used during the SLAAC for DAD (Duplicate Address Detection).