Adding OTA Agent with suspend resume. #37
Conversation
| if( status == MQTTRecvFailed ) | ||
| { | ||
| printf( "ERROR: MQTT Receive failed. Closing connection.\n" ); | ||
| exit( 1 ); |
There was a problem hiding this comment.
Is this closing the connection? Seems like it would kill the demo
There was a problem hiding this comment.
Yes, this can kill the demo. We followed the same approach in the chain of responsibility demo as well.
We can add retries if don't want to stop the demo in case of network failure or connection issues.
|
|
||
| jobIdLength = coreJobs_getJobId( (char *)jobDoc->jobData, jobDoc->jobDataLength, &jobId ); | ||
|
|
||
| /* TODO: Change length to the length of global job id */ |
There was a problem hiding this comment.
Does this still need to be done?
There was a problem hiding this comment.
yes, I think we need to revisit this part to avoid the scenario where the jobIDLength is greater than the maximum job id length.
|
Can you include some testing details? I know you ran the demo but seeing what the output should look like (even if truncated) would be helpful |
|
A README explaining the demo would certainly be nice to have |
|
Discussed offline with @manvensh. This code was specifically written to ONLY ever modify the |
manvensh
force-pushed
the
adding_ota_agent
branch
from
2199b83
to
10f7751
Compare
Working on it and will add it as a part of next PR. |
Adding OTA Agent with suspend resume.
Testing