Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat empty JSON object in key-value pair as valid #169

Merged
merged 6 commits into from
Jul 20, 2024

Conversation

aggarg
Copy link
Member

@aggarg aggarg commented Jul 18, 2024

Description

Without this change, the following valid JSON document will be evaluated as invalid:

{
    "foo": {}
}

Test Steps

Added a unit test.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

#168

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Without this change, the following valid JSON document will be evaluated
as invalid:
```
{
    "foo": {}
}
```

This issue was reported here - FreeRTOS#168

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
@aggarg aggarg requested a review from a team as a code owner July 18, 2024 13:51
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
moninom1
moninom1 previously approved these changes Jul 18, 2024
@aggarg aggarg changed the title Treat empty JSON object as valid Treat empty JSON object in key-value pair as valid Jul 18, 2024
sirnish
sirnish previously approved these changes Jul 18, 2024
Copy link
Member

@sirnish sirnish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtg

source/core_json.c Outdated Show resolved Hide resolved
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
@aggarg aggarg dismissed stale reviews from sirnish and moninom1 via bfb794c July 19, 2024 07:59
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
@aggarg aggarg merged commit 9ebaeb5 into FreeRTOS:main Jul 20, 2024
11 checks passed
@aggarg aggarg deleted the issue_168 branch July 20, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants