-
-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2537] indicate selected ability when targeting #2567
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@weiquu Heya! Um, no resizing of icons please; use other ways for spacing out stuff, like adding extra divs and using code. |
Hey @DreadKnight, I meant scaling the sprites down, not actually changing the |
Doing it through code like that should be ok. I get that this is a draft, just wanted to make sure of this approach aspect. |
@DreadKnight ready for review! |
@weiquu Only did some testing with Firefox, 2 stacked Dark Priests for each player, mouse wheel working badly and no showcased ability icons at all. Will test soon with Brave as well. Also, I understand that icons need to be moved into the autoload folder, but UI should use them from there, it's important to avoid duplicated, but you've changed the icons I think. |
@weiquu You can test it here btw -> https://ancientbeast-9pgv468k0-freezingmoon.vercel.app |
@weiquu Hey, any progress with this one? 🐻 |
This fixes issue #2537
My wallet address is 0x848fBf0588B448f14a2a8BA84Ef12711677073Db
Outline of solution:
Example: