add first tests

.github/workflows/ci.yml

@@ -26,6 +26,9 @@ jobs:
  - name: apt update
  run:
  sudo apt-get update
+ - name: install APT dependencies
+ run:
+ sudo apt-get install fonts-roboto
  - name: update PIP
  run:
  python -m pip install --upgrade pip

brother_ql_web/__main__.py

@@ -6,7 +6,7 @@ def main():
 
  cli_parameters = cli.get_parameters()
  configuration = Configuration.from_json(cli_parameters.configuration)
- configuration = cli.update_configuration_from_parameters(
+ cli.update_configuration_from_parameters(
  configuration=configuration, parameters=cli_parameters
  )
  logging.basicConfig(level=configuration.server.log_level)

brother_ql_web/cli.py

@@ -96,13 +96,14 @@ def _choose_default_font(fonts: dict, configuration: Configuration) -> None:
 
 def update_configuration_from_parameters(
  parameters: Namespace, configuration: Configuration
-) -> Configuration:
+):
  # Server configuration.
  if parameters.port:
  configuration.server.port = parameters.port
  if parameters.log_level:
  # `log_level` will be numeric if parsed from argv, so we enforce the name here.
- configuration.server.log_level = logging.getLevelName(parameters.log_level)
+ level = parameters.log_level
+ configuration.server.log_level = logging.getLevelName(level) if isinstance(level, int) else level
  if parameters.font_folder:
  configuration.server.additional_font_folder = parameters.font_folder
 
@@ -121,7 +122,7 @@ def update_configuration_from_parameters(
  # Configuration issues.
  if configuration.label.default_size not in label_sizes:
  raise InvalidLabelSize(
- "Invalid default label size. Please choose one of the following:\n:"
+ "Invalid default label size. Please choose one of the following:\n"
  + " ".join(label_sizes)
  )
 
@@ -135,5 +136,3 @@ def update_configuration_from_parameters(
 
  # Set font data.
  _choose_default_font(fonts=fonts, configuration=configuration)
-
- return configuration

brother_ql_web/configuration.py

@@ -22,8 +22,13 @@ def from_json(cls, json_file: str):
  name: str = field.name
  field_type: str = cast(str, field.type)
  field_class = global_variables[field_type]
- kwargs_inner = parsed.pop(name)
- instance = field_class(**kwargs_inner)
+ kwargs_inner = parsed.pop(name, None)
+ if name == "printer" and not kwargs_inner:
+ raise ValueError("Printer configuration missing")
+ if not kwargs_inner:
+ instance = field_class()
+ else:
+ instance = field_class(**kwargs_inner)
  kwargs[name] = instance
  if parsed:
  raise ValueError(f"Unknown configuration values: {parsed}")
@@ -51,7 +56,7 @@ class PrinterConfiguration:
  printer: str
 
 
-@dataclass
+@dataclass(frozen=True)
 class Font:
  family: str
  style: str

tests/__init__.py

@@ -1,5 +1,9 @@
 import logging
-from unittest import TestCase # noqa: F401
+from functools import cached_property
+from pathlib import Path
+from unittest import TestCase as _TestCase
+
+from brother_ql_web.configuration import Configuration
 
 
 def patch_deprecation_warning():
@@ -22,3 +26,13 @@ def warn(message, *args, **kwargs):
 
 
 patch_deprecation_warning()
+
+
+class TestCase(_TestCase):
+ @cached_property
+ def example_configuration_path(self) -> str:
+ return str(Path(__file__).parent.parent / "config.example.json")
+
+ @property
+ def example_configuration(self) -> Configuration:
+ return Configuration.from_json(self.example_configuration_path)