Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code #618

Merged
merged 1 commit into from
May 3, 2024
Merged

Remove deprecated code #618

merged 1 commit into from
May 3, 2024

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Mar 28, 2024

No description provided.

@dbu dbu changed the base branch from 2.x to 3.x March 28, 2024 09:43
@usu
Copy link
Contributor

usu commented Apr 30, 2024

I found one more reference to the deprecated fos_http_cache.user_context.logout_handler in ServiceTest

@usu
Copy link
Contributor

usu commented May 1, 2024 •
edited
Loading

Found some more legacy code in Configuration.php:
https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/blob/3.x/src/DependencyInjection/Configuration.php#L59
https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/blob/3.x/src/DependencyInjection/Configuration.php#L620
https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/blob/3.x/src/DependencyInjection/Configuration.php#L657

Also, there are quite some errors with phpstan in this file. Didn't look into it further other than typing errors only.

Edit: included in #621

@usu
Copy link
Contributor

usu commented May 1, 2024 •
edited
Loading

And finally in FlashMessageListener.php, I think the class_alias could just be removed and the reference to the alias further below replaced with the actual ResponseEvent.

https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/blob/3.x/src/EventListener/FlashMessageListener.php#L22
https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/blob/3.x/src/EventListener/FlashMessageListener.php#L57

Edit: included in #622

This was referenced May 1, 2024
Merged
Merged
Closed
@dbu dbu force-pushed the remove-deprecated-code branch 2 times, most recently from 3b71828 to 1afcc77 Compare May 3, 2024 15:57
@dbu dbu force-pushed the remove-deprecated-code branch from 1afcc77 to 987282b Compare May 3, 2024 15:58
@dbu dbu merged commit f343e22 into 3.x May 3, 2024
12 of 13 checks passed
@dbu dbu deleted the remove-deprecated-code branch May 3, 2024 15:59
@dbu
Copy link
Contributor Author

dbu commented May 3, 2024

hooray, the phpunit failure we previously had here went away with the rebase on 3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbu @usu