Clarify build requirements for NTSync5 in .cfg files #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-tkg.cfg ntsync is part of the kernel UAPI, so the presence of the ntsync module on the build host is not required to build Wine with ntsync support. A complete ntsync header file at /usr/include/linux/ntsync.h (replacing, if applicable, the incomplete stub mainlined in kernel 6.10) is sufficient. Note also that the proposed ntsync patchset targets kernels >= 6.8, but builds still work if the build host is running an earlier kernel. This is most immediately relevant for CI, as the ubuntu-latest GitHub Actions runner has kernel 6.5.
|
Yup! |
|
Thanks for accepting these small improvements. From another Galaxy S kernel hobbyist, see you around 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ntsync is part of the kernel UAPI, so the presence of the ntsync module on the build host is not required to build Wine with ntsync support. A complete ntsync header file at /usr/include/linux/ntsync.h (replacing, if applicable, the incomplete stub mainlined in kernel 6.10) is sufficient.
Note also that the proposed ntsync patchset targets kernels >= 6.8, but builds still work if the build host is running an earlier kernel. This is most immediately relevant for CI, as the ubuntu-latest GitHub Actions runner has kernel 6.5.