Fix roll regex, update a bunch of others #214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex for file rolling wasn't anchored to the beginning of the query, so searches such as
!search o:"roll a d20"
were triggering the roll command instead of the search command. That has been fixed.While I was there, I also did some cleanup to the other regexps that we use:
singleQuotedWord
was rewritten to only use matching quotes(a|b|c)
were replaced with[abc]
!rolld20
is not valid (since that's just weird)\S
instead of[^\s]
)I also removed the logic that special-cased Uro as a foreign card. Firstly because I wasn't actually able to replicate the issue (
!uro
just returns Uro even when that thing is removed), and secondly because even if it does appear again, we can fix it just by adding"uro"
into the short names dictionary.