Extend coin flip syntax to support multiple flips #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunakv
force-pushed
the
multiple-coin-flips
branch
2 times, most recently
from
9b38630 to
5e8fa62
Compare
lunakv
force-pushed
the
multiple-coin-flips
branch
from
5e8fa62 to
7a2646d
Compare
Fryyyyy
reviewed
Nov 21, 2023
| @@ -8,7 +8,7 @@ import ( | |||
|
|
|||
| func TestFlipCoin(t *testing.T) { | |||
| for i := 1; i < 10; i++ { | |||
| result := flipCoin() | |||
| result := flipCoin("coin") | |||
There was a problem hiding this comment.
Can we write some tests for the new functionality?
Many coins, too many coins, negative number of coins etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as a small nice-to-have, sometimes you want to flip more than one coin. This PR extends the coin command to support an optional numeric parameter.
Example queries: