Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for latest Win11 interfaces #57

Closed
wants to merge 3 commits into from
Closed

Conversation

Viqsi
Copy link

@Viqsi Viqsi commented Sep 29, 2023

Windows 11 has changed the virtual desktop interface again, this time between build revisions rather than builds (#51).

The actual detective work was done in MScholtes/VirtualDesktop#67; this is just a hamfisted attempt to adapt that to VD.ah2. It may well be inaccurate and/or have bugs because I've only tested the four functions I regularly use (getNameFromDesktopNum, goToDesktopNum, MoveWindowToDesktopNum, and getCurrentDesktopNum). Still, hope this helps.

@FuPeiJiang
Copy link
Owner

@Viqsi
hi, you have committed an update with "microsoft's latest shuffle of the IDs"
is there a version of windows in which the latest version of VD.ahk doesn't work ?

@Viqsi
Copy link
Author

Viqsi commented Mar 4, 2024

@Viqsi hi, you have committed an update with "microsoft's latest shuffle of the IDs" is there a version of windows in which the latest version of VD.ahk doesn't work ?

I've not explicitly tested what you've got in there; this was just me bringing my own fork up to date with the changes in #62 as I got burned by them just now in build 22631.3155. I've not tried to fully reconcile.

@Viqsi
Copy link
Author

Viqsi commented Mar 4, 2024

Gave that commit of yours a try and it looks to solve the problem for me, so I'ma close this PR. (I kind of wish I'd noticed your work earlier, actually... :) ). Thanks!

@Viqsi Viqsi closed this Mar 4, 2024
@FuPeiJiang
Copy link
Owner

for buildNumber = 22621,
you could probably replace
IID_IVirtualDesktopManagerInternal_ := "{A3175F2D-239C-4BD2-8AA0-EEBA8B0B138E}"
with
IID_IVirtualDesktopManagerInternal_ := "{4970BA3D-FD4E-4647-BEA3-D89076EF4B9C}"

{A3175F2D-239C-4BD2-8AA0-EEBA8B0B138E} is IID_IVirtualDesktopManagerInternal2
{4970BA3D-FD4E-4647-BEA3-D89076EF4B9C} is IID_IVirtualDesktopManagerInternal
that's why both work

I have a repo with IID extraction:
https://github.com/FuPeiJiang/Windows-BuildNumber-VirtualDesktop/blob/main/23H2-22631.2715/IID.txt

could you test if my version works for 22631.3155 ?
I included support for Windows Server 2022, but you probably don't need it


I saw that you tested it, so this confirms that Commits with #NUM give no notification
#51
at the bottom, you can see that I added a commit, but there's no notification ?

FuPeiJiang added a commit that referenced this issue 3 weeks ago
@FuPeiJiang
"improvements"; "untested"; #51

sorry, I should type something in the comments/add a comment

@Viqsi
Copy link
Author

Viqsi commented Mar 4, 2024

Yeah, it didn't notify me. I'm not sure why; maybe because I'm using the AHKv2 branch and that commit was a AHKv1 branch. Either way, it seems all good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants