Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement FTI #215

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

feat: implement FTI #215

wants to merge 24 commits into from

Conversation

DefiCake
Copy link
Member

Closes #208

@DefiCake DefiCake self-assigned this Jun 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024 •
edited
Loading

This PR is published in NPM with version ****

@DefiCake DefiCake marked this pull request as ready for review June 25, 2024 17:27
@DefiCake DefiCake requested a review from a team as a code owner June 25, 2024 17:27
@DefiCake DefiCake requested a review from luizstacio July 25, 2024 17:56
K1-R1
K1-R1 reviewed Jul 31, 2024
View reviewed changes
Copy link
Member

@K1-R1 K1-R1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, a couple of nits but otherwise LGTM

packages/solidity-contracts/contracts/test/EthReceiver.sol Outdated Show resolved Hide resolved
packages/test-utils/src/utils/setup.ts Outdated Show resolved Hide resolved
@K1-R1 K1-R1 requested a review from a team July 31, 2024 17:40
@DefiCake @K1-R1
Update packages/solidity-contracts/contracts/test/EthReceiver.sol
4d2fff0 
Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
@K1-R1 K1-R1 requested a review from a team August 2, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1-R1 K1-R1 K1-R1 approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio

At least 2 approving reviews are required to merge this pull request.

Assignees

@DefiCake DefiCake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement forced transaction inclusion (FTI) in FuelMessagePortal
2 participants
@DefiCake @K1-R1