Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move complex CI worfklow logic into scripts #2581

Open
nedsalk opened this issue Jun 23, 2024 · 1 comment
Open

Move complex CI worfklow logic into scripts #2581

nedsalk opened this issue Jun 23, 2024 · 1 comment
Labels
chore Issue is a chore

Comments

@nedsalk
Copy link
Contributor

nedsalk commented Jun 23, 2024

CI workflows, especially those related to changesets and release processes, have recently experienced a lot of expansion and have become rather cumbersome to read. Besides that, CI testing most of the time requires a lot of trial and error. We should move their logic to either shell or typescript scripts to make them more manageable and ideally write unit tests for existing logic and have the infrastructure ready for future logic to reduce trial and error.

Caution

High caution needs to be exercised here to not break things.

@mvares
Copy link
Contributor

mvares commented Jun 23, 2024

hey @nedsalk, I suggest some additions to make this logic more understandable. Here's:

  • Break these scripts into separate files
  • Review the script code (Maybe we can improve it somehow)
  • Create an improvement proposal explaining some technical decisions

PS: The third point will (maybe) resolve this.

@arboleya arboleya added this to the 0.x post-launch milestone Jun 23, 2024
@arboleya arboleya added the p1 label Jun 23, 2024
@arboleya arboleya added p2 and removed p1 labels Jul 19, 2024
@arboleya arboleya removed this from the 0.x post-launch milestone Jul 19, 2024
@arboleya arboleya removed the p2 label Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

No branches or pull requests

3 participants