-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add infrastructure to patch latest version #2497
Conversation
ba71acb
to
8ad5fcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we document the process as we did for patching old releases?
Lines 240 to 248 in 269197f
# Patching old releases | |
The following example is for releasing a patch for `v0.69.0` -> `v0.69.1`. | |
- Checkout the release commit via its tag and create a release branch based on it (`git checkout -b release/0.69.0 v0.69.0 && git push --set-upstream origin release/0.69.0`) | |
- Create PRs with base set to that release branch | |
- When the PR is merged, a changeset PR is created | |
- When the changeset PR is merged into the release branch, the next patch version is released and the commit is tagged (e.g. `v0.69.1`) | |
- After release, delete the release branch from GitHub |
75b22c1
to
134c330
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, how do we test these type of release workflows?
@petertonysmith94 The actual full workflow would be tested in the trenches after we merge it into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nedsalk thanks for explaining, super valuable insight - got to love some trenches testing 😆
It looks good me 🚀
Coverage Report:
Changed Files:Coverage values did not change👌. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firstly, thanks for addressing this final piece on our release process.
Having said that, I couldn't properly validate it. I mean no offense, but the changes in this PR are too convoluted and unreadable (hard to follow). If we add the fact that it is purely text (CI/YAML), the job becomes even more challenging. It is like validating code on a piece of paper.
I know others have approved it, but I wonder if they could accurately explain it back to you.
I'll go ahead and approve it as is so you can validate it yourself in practical terms. I suggest doing that in isolation at the beginning of your day so you can see it through and make any extra fixes on the spot if necessary.
This PR adds infrastructure to patch the last release. Given that this workflow releases commits that are not on
master
, we'll have to manually apply those commits' changes tomaster
if the released code doesn't already exist on it.Besides the release of the package itself, the documentation also gets updated when this scenario occurs.
closes #2245